Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix @SofaService Annotation parse #1194

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/L labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1194 (3bd5285) into master (ec5a084) will decrease coverage by 0.02%.
The diff coverage is 93.75%.

@@             Coverage Diff              @@
##             master    #1194      +/-   ##
============================================
- Coverage     71.41%   71.40%   -0.02%     
- Complexity     1817     1820       +3     
============================================
  Files           253      254       +1     
  Lines          7354     7361       +7     
  Branches        931      932       +1     
============================================
+ Hits           5252     5256       +4     
- Misses         1623     1625       +2     
- Partials        479      480       +1     
Impacted Files Coverage Δ
...om/alipay/sofa/boot/util/SmartAnnotationUtils.java 90.00% <90.00%> (ø)
...untime/spring/ServiceBeanFactoryPostProcessor.java 74.45% <100.00%> (-0.41%) ⬇️

... and 1 file with indirect coverage changes

@crazysaltfish crazysaltfish self-requested a review June 21, 2023 07:23
Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit b6c7763 into sofastack:master Jun 21, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants