Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where @SofaService annotation cannot set a custom threa… #1247

Merged

Conversation

HzjNeverStop
Copy link
Contributor

…d pool when the interfaceType is empty

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (b274315) 84.15% compared to head (7be8e71) 84.24%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1247      +/-   ##
============================================
+ Coverage     84.15%   84.24%   +0.09%     
- Complexity     2865     2866       +1     
============================================
  Files           323      323              
  Lines          9314     9318       +4     
  Branches       1113     1113              
============================================
+ Hits           7838     7850      +12     
+ Misses          973      961      -12     
- Partials        503      507       +4     
Files Changed Coverage Δ
...pc/boot/runtime/converter/RpcBindingConverter.java 79.09% <100.00%> (+2.09%) ⬆️
...a/runtime/spi/service/BindingConverterContext.java 92.00% <100.00%> (+1.09%) ⬆️
...untime/spring/ServiceBeanFactoryPostProcessor.java 74.45% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 703de86 into sofastack:master Sep 20, 2023
4 checks passed
HzjNeverStop added a commit to HzjNeverStop/sofa-boot that referenced this pull request Sep 25, 2023
HzjNeverStop added a commit that referenced this pull request Sep 28, 2023
* init interface class canonical name to avoid multi reflection

* Fix the issue where @SofaService annotation cannot set a custom thread pool when the interfaceType is empty (#1247)

---------

Co-authored-by: 致节 <hzj266771@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants