Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick 1254 #1260

Merged
merged 6 commits into from Oct 23, 2023
Merged

Cherrypick 1254 #1260

merged 6 commits into from Oct 23, 2023

Conversation

HzjNeverStop
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ced1622) 72.25% compared to head (a0fc300) 72.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x    #1260      +/-   ##
============================================
+ Coverage     72.25%   72.37%   +0.12%     
- Complexity     1976     1979       +3     
============================================
  Files           269      269              
  Lines          7817     7822       +5     
  Branches        996      996              
============================================
+ Hits           5648     5661      +13     
+ Misses         1664     1651      -13     
- Partials        505      510       +5     
Files Coverage Δ
...ot/autoconfigure/rpc/SofaRpcAutoConfiguration.java 62.50% <100.00%> (+3.67%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@crazysaltfish crazysaltfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit 3b803af into sofastack:3.x Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants