Add encoding utils #179
Merged
Add encoding utils #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 19, 2023 11:27
2. add CharsetUtil
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
============================================
+ Coverage 34.60% 34.73% +0.13%
- Complexity 662 676 +14
============================================
Files 75 76 +1
Lines 5627 5674 +47
Branches 1075 1089 +14
============================================
+ Hits 1947 1971 +24
- Misses 3436 3450 +14
- Partials 244 253 +9
|
added 2 commits
May 29, 2023 10:44
|
I don't think it is a good idea to check if a byte array is UTF-8 encoded. It is more reasonable to test if default charset is UTF-8. |
ujjboy
requested changes
May 29, 2023
| */ | ||
| public class CharsetUtil { | ||
|
|
||
| public static Logger CHARSET_MONITOR_LOG = LoggerFactory.getLogger("CHARSET_MONITOR_LOG"); |
There was a problem hiding this comment.
这个配置方式是希望用户自己配 CHARSET_MONITOR_LOG 吗？
There was a problem hiding this comment.
这个配置方式是希望用户自己配 CHARSET_MONITOR_LOG 吗？
是的，用户自己配置 LOGGER 更加灵活，例如可以为日志打印添加MDC（traceId、方法入参）
This utility class is used to detect whether a system that uses UTF-8 encoding has read non-UTF-8 encoded data from other data streams. |
added 2 commits
May 29, 2023 15:40
HzjNeverStop
added a commit
to HzjNeverStop/sofa-common-tools
that referenced
this pull request
Jun 2, 2023
(cherry picked from commit efa6342)
HzjNeverStop
added a commit
that referenced
this pull request
Jun 2, 2023
HzjNeverStop
added a commit
that referenced
this pull request
Jun 28, 2023
* 2.0.0 (#176) - 升级 JDK17 - 适配 slf4j2 与 reload4j - 升级 log4j2 与 logback 版本 - 移除 @deprecated 代码 * 2.0.0 fix javadoc (#177) * use reload log4j (#178) Co-authored-by: “HzjNeverStop” <“441627022@qq.com”> * use singleton console appender for space * update CommonLoggingConfigurations * update maven stage plugin to 1.6.13 * Merge 1.3.11 (#182) * Add encoding utils (#179) (cherry picked from commit efa6342) * Add LegacySpringBanUtil (#180) Co-authored-by: “HzjNeverStop” <“441627022@qq.com”> (cherry picked from commit 99d321b) * release 2.0.0 (#183) Co-authored-by: “HzjNeverStop” <“441627022@qq.com”> --------- Co-authored-by: “HzjNeverStop” <“441627022@qq.com”>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.