Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roll back previous throwable and stack trace element ser for compatibility #111

Merged
merged 2 commits into from Apr 1, 2024

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Mar 8, 2024

add original throwable serializer and stackTraceElement deserializer for compatible use.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/L labels Mar 8, 2024
@Lo1nt Lo1nt requested a review from EvenLjj March 8, 2024 09:36
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.73%. Comparing base (da95611) to head (80307c1).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x     #111      +/-   ##
==========================================
- Coverage   28.75%   28.73%   -0.03%     
==========================================
  Files         173      175       +2     
  Lines       11864    11867       +3     
  Branches     2134     2134              
==========================================
- Hits         3412     3410       -2     
- Misses       8091     8094       +3     
- Partials      361      363       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt merged commit d1d810a into sofastack:3.x Apr 1, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants