Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer monotonic time for lastLeaderTimestamp #24

Closed
killme2008 opened this issue Mar 8, 2019 · 0 comments
Closed

Prefer monotonic time for lastLeaderTimestamp #24

killme2008 opened this issue Mar 8, 2019 · 0 comments
Assignees
@fengjiachun
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
v1.2.4
Milestone
1.2.4

Comments

@killme2008
Copy link
Contributor

It's better to use monotonic time for lastLeaderTimestamp in NodeImpl.It represents the last timestamp that the node received request from leader, and it should be monotonic.
@killme2008 killme2008 added good first issue Good for newcomers enhancement New feature or request labels Mar 8, 2019
@fengjiachun fengjiachun added this to the 1.2.4 milestone Mar 8, 2019
@fengjiachun fengjiachun added this to To do in v1.2.4 via automation Mar 8, 2019
@fengjiachun fengjiachun self-assigned this Mar 8, 2019
killme2008 pushed a commit that referenced this issue Mar 9, 2019
(fix) Use monotonic time for lastLeaderTimestamp and refactor, #24
32d3f7c
@killme2008 killme2008 mentioned this issue Mar 9, 2019
Merged
fengjiachun pushed a commit that referenced this issue Mar 10, 2019
@killme2008 @fengjiachun
Fix/lease read stale (#26)
aab1c61 
* (fix) Ignore preVote request if there is a leader that it's lease is still valid.

* (fix) Use monotonic time for lastLeaderTimestamp and refactor, #24

* (fix) typo and error log
v1.2.4 automation moved this from To do to Done Mar 10, 2019
This was referenced Mar 20, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengjiachun fengjiachun

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
v1.2.4
  
Done
Milestone
1.2.4
Development

No branches or pull requests
2 participants
@killme2008 @fengjiachun