Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/design smells #1098

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor/design smells #1098

wants to merge 3 commits into from

Commits on Mar 31, 2024

  1. Refactor: 

    BatchRawKVStore class has insufficient modularization.
Add:
BatchRawPutOperations to separate Put operations.
BatchRawDeleteOperations to separate Delete operations.
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    a1dcd90 View commit details
    Browse the repository at this point in the history

  2. Smell: start is more interested in members of the type: StartupConf 

    Refactor:
Move Method to StartupConf
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    2f8d90c View commit details
    Browse the repository at this point in the history

  3. Refactor: Change bidirectional association to unidirectional association 

    CounterServer: class participates in a cyclic dependency. The participating classes in the cycle are: CounterServiceImpl; CounterServer
    @JAYDIPSINH27
    JAYDIPSINH27 committed Mar 31, 2024
    Configuration menu
    Copy the full SHA
    883e270 View commit details
    Browse the repository at this point in the history