(bugfix) fix rheakv state machine bug #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add some unit test |
…ugfix/halt_on_exception # Conflicts: # jraft-rheakv/rheakv-core/src/main/java/com/alipay/sofa/jraft/rhea/storage/KVStoreStateMachine.java
|
存在冲突 |
|
和 #154 冲突了，我先解决下 |
killme2008
reviewed
May 8, 2019
| @@ -84,8 +84,7 @@ public Status rangeSplit(final long regionId, final long newRegionId, final Stri | |||
| if (response.isSuccess()) { | |||
| return Status.OK(); | |||
| } | |||
| return new Status(-1, "fail to range split on region %d, error: %s", regionId, String.valueOf(response | |||
| .getError())); | |||
| return new Status(-1, "Fail to range split on region %d, error: %s", regionId, String.valueOf(response)); | |||
There was a problem hiding this comment.
不需要调用 String.valueOf 吧？ 格式化会 %s 自动调用 toString
killme2008
reviewed
May 8, 2019
| assert first != null; | ||
| batchApplyAndRecycle(first.getOpByte(), kvStates); | ||
| } catch (final Throwable t) { | ||
| it.setErrorAndRollback(index - applied, new Status(RaftError.EIO, "StateMachine meet critical error: %s.", |
There was a problem hiding this comment.
RaftError 选择 ESTATEMACHINE 更合适，并且这里建议加下日志，打印出堆栈
killme2008
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If rheakv caught a critical error, should halt the state machine to avoid they inconsistencies between different nodes.
Modification:
As above describe.
Result:
Fixes #136