(feat) Refused requests when node is overload, #138 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
May 5, 2019
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeMetrics.java
Outdated
Show resolved
Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/impl/LogManagerImpl.java
Show resolved
Hide resolved
* (feat) Auto select Thread.onSpinWait instead of Thread.yield when above jdk9 * (fix) insure that we always have a spinner * (fix) code format * (fix) insure that we always have a spinner
…ft into feature/process-overload
fengjiachun
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix #138 , refused new requests when the raft node is overload.
Modification:
DisruptorBuilderto build disruptor, refactor code.tryPublishEventto replacepublishEventinNodeImpl#applyandReadOnlyServiceImpl#addRequestto defense overload requests.TimeoutBlockingWaitStrategyforLogManagerImpldisruptor, whendiskQueueis overload, it will wait at most 10 seconds(setting byRaftOptions#disruptorPublishEventWaitTimeoutSecs) to put new event. If timed out, the node will be halt.NodeTest#testNodeTaskOverload