Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ReplicatorStateListener for Replicator consecutiveErrorTimes enhancement #256

Merged
merged 14 commits into from
Aug 27, 2019
Merged

Implement ReplicatorStateListener for Replicator consecutiveErrorTimes enhancement #256

merged 14 commits into from
Aug 27, 2019

Conversation

zongtanghu
Copy link
Contributor

Modification:
(1)Implement ReplicatorStateListener for the issue that Replicator consecutiveErrorTimes enhancement.
(1)Implement serveral related Test Unit Class.

Result:
Fixes #197

If there is no issue then describe the changes introduced by this PR.

SteNicholas
SteNicholas reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

按照JRaft代码格式修改下~

jraft-core/src/main/java/com/alipay/sofa/jraft/Node.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/ReplicatorGroup.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/Replicator.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/Replicator.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/Replicator.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/Replicator.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/ReplicatorGroupTest.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/ReplicatorGroupTest.java Outdated Show resolved Hide resolved
@sofastack-bot sofastack-bot bot added size/XL and removed size/L labels Aug 22, 2019
@killme2008
Copy link
Contributor

@zongtanghu 提了一些意见，还请再看下，谢谢

@fengjiachun fengjiachun self-requested a review August 22, 2019 13:09
fengjiachun
fengjiachun reviewed Aug 22, 2019
View reviewed changes
jraft-core/src/main/java/com/alipay/sofa/jraft/Node.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/Node.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/core/Replicator.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/NodeTest.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/NodeTest.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/ReplicatorGroupTest.java Outdated Show resolved Hide resolved
jraft-core/src/test/java/com/alipay/sofa/jraft/core/ReplicatorTest.java Outdated Show resolved Hide resolved
@zongtanghu
Copy link
Contributor Author

zongtanghu commented Aug 22, 2019 via email

@sofastack-bot sofastack-bot bot removed the size/XL label Aug 23, 2019
@fengjiachun
Copy link
Contributor

@zongtanghu 代码需要格式化一下 mvn clean compile

@zongtanghu
Copy link
Contributor Author

@zongtanghu 代码需要格式化一下 mvn clean compile

done

@zongtanghu
Copy link
Contributor Author

I have already adjusted codes, code styles and comments! @fengjiachun @killme2008 @SteNicholas

@fengjiachun fengjiachun merged commit 5baccae into sofastack:master Aug 27, 2019
@zongtanghu zongtanghu mentioned this pull request Aug 27, 2019
Closed
@fengjiachun fengjiachun added this to In progress in v1.3.0 via automation Aug 29, 2019
@fengjiachun fengjiachun added this to the 1.2.7 milestone Aug 29, 2019
@fengjiachun fengjiachun moved this from In progress to Done in v1.3.0 Aug 29, 2019
@fengjiachun fengjiachun mentioned this pull request Nov 29, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

@SteNicholas SteNicholas SteNicholas approved these changes

Assignees
No one assigned
Labels
cla:yes size/L
Projects
No open projects
v1.3.0
  
Done
Milestone
1.2.7
Development

Successfully merging this pull request may close these issues.

Replicator consecutiveErrorTimes enhancement
4 participants
@zongtanghu @killme2008 @fengjiachun @SteNicholas