(feat) contains key api #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengjiachun
reviewed
Oct 21, 2019
| } | ||
|
|
||
| private void internalContainsKey(final byte[] key, final CompletableFuture<Boolean> future, | ||
| final int retriesLeft, final Errors lastCause) { |
| /** | ||
| * Returns whether database contains the specified input key. | ||
| * | ||
| * @param key the specified key database contains. |
| public void containsKey(final byte[] key, final KVStoreClosure closure) { | ||
| final Timer.Context timeCtx = getTimeContext("CONTAINS_KEY"); | ||
| try { | ||
| final Boolean isContains = this.defaultDB.containsKey(key); |
There was a problem hiding this comment.
final boolean exists = this.defaultDB.containsKey(key);
| @@ -153,7 +153,8 @@ private void doStatistics() { | |||
| KVMetrics.counter(REGION_BYTES_WRITTEN, id).inc(this.bytesWritten); | |||
| break; | |||
| } | |||
| case KVOperation.GET: { | |||
| case KVOperation.GET: | |||
| case KVOperation.CONTAINS_KEY: { | |||
| final Lock readLock = this.readWriteLock.readLock(); | ||
| readLock.lock(); | ||
| try { | ||
| final Boolean isContains = this.db.keyMayExist(key, new StringBuilder(0)); |
There was a problem hiding this comment.
final boolean exists = this.db.keyMayExist(key, new StringBuilder(0));
fengjiachun
reviewed
Oct 22, 2019
| readLock.lock(); | ||
| try { | ||
| final boolean exists = this.db.keyMayExist(key, new StringBuilder(0)); | ||
| setSuccess(closure, exists); |
There was a problem hiding this comment.
boolean exists = false;
if (this.db.keyMayExist(key, new StringBuilder(0))) {
exists = this.db.get(key) != null;
}
应该是这样的逻辑
fengjiachun
approved these changes
Oct 22, 2019
luozhiyun993
pushed a commit
to luozhiyun993/sofa-jraft
that referenced
this pull request
Nov 25, 2019
* 'master' of https://github.com/sofastack/sofa-jraft: (feat) Remove multiple of 10ms for windows platform. (sofastack#351) (feat) add thread pool metric report (sofastack#339) [ISSUE#347]upgrade the com.fasterxml.jackson.core:jackson-databind to version 2.9.10.1. (sofastack#352) (feat) Support readIndex from learner (sofastack#343) (feat) counter example (sofastack#318) minor fixes (sofastack#336) Impl learner for jraft, sofastack#8 (sofastack#312) (fix) Declare rpcClient to be volatile, fix sofastack#319 (sofastack#323) (feat) add current leader id to node describe (sofastack#322) (fix) fix remove metric failed on replicator destroy (sofastack#325) (fix) raft options copy (sofastack#321) (feat) contains key api (sofastack#302) (feat) add rocksdb table_format_config and statistics (sofastack#295) feat/async snapshot (sofastack#287) fix/state listener (sofastack#285)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provide containsKey(byte[] key) method similar to get(byte[] key) etc.
Modification:
RheaKVStore provide containsKey(byte[] key) method similar to get(byte[] key) etc.
Result:
Fixes #290