Feature/backpressure #764
Merged
Feature/backpressure #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode, and improve disruptor usage
…s busy while replicating logs
killme2008
requested review from
horizonzy,
fengjiachun and
zongtanghu
and removed request for
horizonzy and
fengjiachun
fengjiachun
reviewed
Feb 18, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
horizonzy
reviewed
Feb 24, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java
Outdated
Show resolved
Hide resolved
horizonzy
reviewed
Feb 24, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/core/ReadOnlyServiceImpl.java
Outdated
Show resolved
Hide resolved
horizonzy
reviewed
Feb 24, 2022
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/impl/LogManagerImpl.java
Outdated
Show resolved
Hide resolved
horizonzy
reviewed
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Right now when the raft node is overloaded, it will trap into error state and can't service any more until restart it by manual. It's not acceptable in many cases.In this PR, i try to improve the backpressure mechanism.
It introduces
ApplyTaskModeforNode#apply(task)andNode#readIndex(task)which determins submmitting tasks to node in blocking or non-blocking mode,ApplyTaskMode.NonBlockingby default. In blocking mode, it will block the invocation to these two methods when node is overloaded, and throwsOverloadExceptionimmediately in non-blocking mode instead.The PR also Improves disruptor usage in jraft to prevent deadlocking such as #138 #720 etc.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #754 #720
Doc PR sofastack/sofastack.tech#853