Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot temporary directory support configurable #933

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Snapshot temporary directory support configurable #933

merged 1 commit into from
Mar 15, 2023

Conversation

qiujiayu
Copy link
Contributor

Motivation:

#932

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@qiujiayu qiujiayu force-pushed the snapshotTempPath branch 5 times, most recently from 81446ad to c6d31fd Compare February 14, 2023 11:39
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Feb 14, 2023
@qiujiayu qiujiayu force-pushed the snapshotTempPath branch 2 times, most recently from b111172 to 264cc94 Compare February 14, 2023 12:41
@sofastack-bot sofastack-bot bot added size/M and removed size/L labels Feb 14, 2023
killme2008
killme2008 reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks. There are some minor comments.

jraft-core/src/main/java/com/alipay/sofa/jraft/storage/snapshot/local/LocalSnapshotStorage.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/snapshot/local/LocalSnapshotStorage.java Outdated Show resolved Hide resolved
jraft-core/src/main/java/com/alipay/sofa/jraft/storage/snapshot/local/LocalSnapshotStorage.java Outdated Show resolved Hide resolved
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Feb 17, 2023
@fengjiachun
Copy link
Contributor

@killme2008 PTAL

fengjiachun
fengjiachun approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit ba66daa into sofastack:master Mar 15, 2023
@fengjiachun
Copy link
Contributor

Thanks @qiujiayu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qiujiayu @fengjiachun @killme2008