Feature buckets #37
Merged
Feature buckets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 6, 2018 20:43
luyiisme
reviewed
Sep 17, 2018
client/lookout-core/src/main/java/com/alipay/lookout/core/DefaultRegistry.java
Show resolved
Hide resolved
| } else { | ||
| iterator = priorityMetricsCache.getMetricByPriority(priority).iterator(); | ||
| } | ||
| return new MetricIterator(iterator); |
There was a problem hiding this comment.
SchedulerPoller是主动push模式的一个遍历模式。 新的master代码有了pull 模式，也有个定时遍历逻辑。 稳妥， MetricInterator的封装，尽量提前封装（比如regsitry 的 interator 对象）。 这样无论外部几个遍历主体也没关系。
...nt/lookout-reg-server/src/main/java/com/alipay/lookout/remote/step/LookoutBucketCounter.java
Show resolved
Hide resolved
|
|
||
| @Override | ||
| public Indicator measure() { | ||
| long now = Clock.SYSTEM.wallTime(); |
There was a problem hiding this comment.
上报的时间要对齐下：lastInitPos.get() * step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
add buckets support to DistributionSummay and Timer
Modification:
add two methods:
DistributionSummay.buckets(long[] buckets)
Timer.buckets(long[] buckets)
add a base class BucketCounter to implement buckets
bucketed metrics will create new metrics with name original_metric_name.buckets and a new tag _bucket and tag values like 0-10,10-100 ... 10000-