Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timeout log #771

Merged
merged 1 commit into from Aug 14, 2019
Merged

add timeout log #771

merged 1 commit into from Aug 14, 2019

Conversation

taoyuanyuan
Copy link
Contributor

Issues associated with this PR

add timeout log

Sign the CLA

Make sure you have signed the CLA

Solutions

add timeout log

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result

Code Style

  • Make sure Goimports has run
  • Show Golint result

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #771 into stable will decrease coverage by 0.27%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #771      +/-   ##
==========================================
- Coverage    51.5%   51.23%   -0.28%     
==========================================
  Files         205      205              
  Lines       17020    17145     +125     
==========================================
+ Hits         8766     8784      +18     
- Misses       7360     7461     +101     
- Partials      894      900       +6
Impacted Files Coverage Δ
pkg/proxy/downstream.go 34.29% <33.33%> (-0.05%) ⬇️
pkg/buffer/iobuffer.go 75.31% <0%> (-2.52%) ⬇️
pkg/stream/http/stream.go 12.68% <0%> (+2.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d9c07...3399d39. Read the comment docs.

@nejisama nejisama merged commit 152e1f8 into stable Aug 14, 2019
@nejisama nejisama deleted the minorfix_timeout_log branch August 26, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants