Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric sync_delta and sync_all with datacenter label #298

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

nocvalight
Copy link
Member

Result:

Fixes #297

  • metric sync_delta and sync_all with datacenter label
  • metric push delay with datacenter label

@nocvalight nocvalight added the multi-datacenter support publishers sync between multi datacenter label Feb 28, 2023
@nocvalight nocvalight added this to the 6.2.1 milestone Feb 28, 2023
@nocvalight nocvalight self-assigned this Feb 28, 2023
@sofastack-bot sofastack-bot bot added size/M and removed size/L labels Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #298 (f74f4bc) into master (ee5c2fd) will decrease coverage by 0.15%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #298      +/-   ##
============================================
- Coverage     76.51%   76.36%   -0.15%     
  Complexity       48       48              
============================================
  Files           492      492              
  Lines         18239    18239              
  Branches       1783     1783              
============================================
- Hits          13955    13928      -27     
- Misses         3482     3506      +24     
- Partials        802      805       +3     
Impacted Files Coverage Δ
...y/sofa/registry/common/model/store/Subscriber.java 72.43% <ø> (-0.47%) ⬇️
...lipay/sofa/registry/server/data/timer/Metrics.java 93.75% <ø> (+2.84%) ⬆️
...sofa/registry/server/session/push/PushMetrics.java 92.30% <25.00%> (-1.71%) ⬇️
...ta/multi/cluster/slot/MultiClusterSlotMetrics.java 84.09% <88.23%> (+0.75%) ⬆️
.../client/handler/RemoteDataChangeNotifyHandler.java 94.11% <100.00%> (ø)
...ulti/cluster/slot/MultiClusterSlotManagerImpl.java 77.39% <100.00%> (-3.43%) ⬇️
...y/sofa/registry/server/session/push/PushTrace.java 73.38% <100.00%> (ø)
...erver/meta/slot/arrange/ScheduledSlotArranger.java 74.38% <0.00%> (-5.79%) ⬇️
...ofa/registry/server/session/store/DataIndexer.java 82.25% <0.00%> (-3.23%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5c2fd...f74f4bc. Read the comment docs.

@nocvalight nocvalight merged commit de957a3 into sofastack:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes multi-datacenter support publishers sync between multi datacenter size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record sync_delta and sync_all metric in datacenter label
2 participants