Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get remote slottable from local meta leader fail when meta leader not… #300

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

nocvalight
Copy link
Member

… warmup

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #299 .

If there is no issue then describe the changes introduced by this PR.

@nocvalight nocvalight self-assigned this Feb 28, 2023
@nocvalight nocvalight added the multi-datacenter support publishers sync between multi datacenter label Feb 28, 2023
@nocvalight nocvalight added this to the 6.2.1 milestone Feb 28, 2023
@sofastack-bot sofastack-bot bot added question Further information is requested cla:yes size/M and removed multi-datacenter support publishers sync between multi datacenter labels Feb 28, 2023
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #300 (cfd9d16) into master (de957a3) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
- Coverage     76.42%   76.37%   -0.06%     
  Complexity       48       48              
============================================
  Files           492      493       +1     
  Lines         18239    18248       +9     
  Branches       1783     1783              
============================================
- Hits          13940    13937       -3     
- Misses         3497     3507      +10     
- Partials        802      804       +2     
Impacted Files Coverage Δ
...y/sofa/registry/common/model/store/Subscriber.java 72.43% <0.00%> (ø)
.../client/handler/RemoteDataChangeNotifyHandler.java 94.11% <ø> (ø)
...ulti/cluster/slot/MultiClusterSlotManagerImpl.java 77.39% <ø> (-0.23%) ⬇️
...lipay/sofa/registry/server/data/timer/Metrics.java 93.75% <ø> (ø)
...sofa/registry/server/session/push/PushMetrics.java 92.30% <50.00%> (ø)
...gistry/exception/MetaLeaderNotWarmupException.java 66.66% <66.66%> (ø)
...ta/multi/cluster/slot/MultiClusterSlotMetrics.java 84.09% <100.00%> (ø)
...ti/cluster/DefaultMultiClusterSlotTableSyncer.java 91.92% <100.00%> (+0.15%) ⬆️
...y/sofa/registry/server/session/push/PushTrace.java 73.38% <100.00%> (ø)
...ofa/registry/server/session/store/DataIndexer.java 85.48% <0.00%> (-4.84%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de957a3...cfd9d16. Read the comment docs.

@nocvalight nocvalight merged commit 508ae48 into sofastack:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes question Further information is requested size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants