Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support localStorage mode on sdk-base #109

Merged
merged 2 commits into from
Dec 21, 2022
Merged

feat: support localStorage mode on sdk-base #109

merged 2 commits into from
Dec 21, 2022

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Dec 21, 2022

@fengmk2 fengmk2 added the enhancement New feature or request label Dec 21, 2022
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #109 (3abc1d1) into master (943825a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          38       38           
  Lines        4288     4298   +10     
  Branches      899      905    +6     
=======================================
+ Hits         4211     4221   +10     
  Misses         77       77           
Impacted Files Coverage Δ
lib/client/consumer.js 98.79% <100.00%> (ø)
lib/server/server.js 99.36% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 marked this pull request as ready for review December 21, 2022 12:15
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit be9a630 into master Dec 21, 2022
@fengmk2 fengmk2 deleted the contextStorage branch December 21, 2022 14:14
fengmk2 pushed a commit that referenced this pull request Dec 21, 2022
[skip ci]

## [2.8.0](v2.7.0...v2.8.0) (2022-12-21)

### Features

* support localStorage mode on sdk-base ([#109](#109)) ([be9a630](be9a630))
@github-actions
Copy link

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants