Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 NEW: Support localStorage getter #21

Merged
merged 4 commits into from
Dec 8, 2022
Merged

📦 NEW: Support localStorage getter #21

merged 4 commits into from
Dec 8, 2022

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 8, 2022

No description provided.

Breaking change on ts import
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #21 (e041ea3) into master (c75bab2) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          243       251    +8     
  Branches        68        69    +1     
=========================================
+ Hits           243       251    +8     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fengmk2 fengmk2 changed the title 📦 NEW: [BREAKING] Support localStorage getter 📦 NEW: Support localStorage getter Dec 8, 2022
}

export default class Base extends EventEmitter {
constructor(option?: BaseOptions);
export default class Base<TContext = any> extends EventEmitter {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

又学会新招

@fengmk2 fengmk2 merged commit 71d7ddd into master Dec 8, 2022
@fengmk2 fengmk2 deleted the AsyncLocalStorage branch December 8, 2022 16:01
@fengmk2
Copy link
Member Author

fengmk2 commented Dec 8, 2022

4.2.0

Copy link
Member

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants