Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default connection pool size of RestClient to 80. #129

Merged
merged 1 commit into from
May 17, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 17, 2018

Motivation:

Set default connection pool size of RestClient to 80.

Modification:

  • Set default connection pool size of RestClient to 80.
  • Add multiple threads example of rest client.

Result:

Fixes #128 at 5.4.x

@ujjboy ujjboy added the bug Something isn't working label May 17, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone May 17, 2018
@ujjboy ujjboy added this to To do in v5.4.x via automation May 17, 2018
@codecov-io
Copy link

Codecov Report

Merging #129 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     65.33%   65.34%   +<.01%     
+ Complexity      657      656       -1     
============================================
  Files           272      272              
  Lines         11620    11620              
  Branches       1955     1955              
============================================
+ Hits           7592     7593       +1     
+ Misses         3065     3062       -3     
- Partials        963      965       +2
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/transport/rest/RestClientTransport.java 92.59% <100%> (ø) 4 <0> (ø) ⬇️
...pay/sofa/rpc/client/aft/InvocationStatFactory.java 82.92% <0%> (-4.88%) 15% <0%> (-1%)
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 84.44% <0%> (-2.23%) 26% <0%> (-1%)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 83.92% <0%> (-1.79%) 0% <0%> (ø)
...pay/sofa/rpc/transport/ClientTransportFactory.java 65.15% <0%> (+4.54%) 0% <0%> (ø) ⬇️
...m/alipay/sofa/rpc/module/FaultToleranceModule.java 93.33% <0%> (+26.66%) 5% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b74d34...7a83b28. Read the comment docs.

@ujjboy ujjboy merged commit d4af480 into sofastack:master May 17, 2018
v5.4.x automation moved this from To do to Done May 17, 2018
@ujjboy ujjboy deleted the fix_issue_128 branch May 17, 2018 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v5.4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants