Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sofaboot 4.0 support #1356

Merged
merged 22 commits into from
Aug 28, 2023
Merged

Sofaboot 4.0 support #1356

merged 22 commits into from
Aug 28, 2023

Conversation

Lo1nt
Copy link
Collaborator

@Lo1nt Lo1nt commented Aug 8, 2023

Motivation:

support SofaBoot 4.0

Modification:

fix several compatible cases under jdk17

Result:

bump javassist so that toClass could run under jdk17
bump hessian
bump dubbo to 3.1.8

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/L labels Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1356 (b30aaeb) into master (666261d) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1356      +/-   ##
============================================
- Coverage     72.03%   72.01%   -0.02%     
+ Complexity      784      783       -1     
============================================
  Files           416      416              
  Lines         17661    17661              
  Branches       2752     2752              
============================================
- Hits          12722    12719       -3     
- Misses         3537     3542       +5     
+ Partials       1402     1400       -2     
Files Changed Coverage Δ
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 54.05% <ø> (ø)
.../main/java/com/alipay/sofa/rpc/common/Version.java 100.00% <ø> (ø)
.../alipay/sofa/rpc/log/factory/RpcLoggerFactory.java 77.77% <ø> (ø)
...fa/rpc/bootstrap/dubbo/DubboConsumerBootstrap.java 84.21% <100.00%> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboConvertor.java 90.00% <100.00%> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboSingleton.java 88.88% <100.00%> (ø)
...alipay/sofa/rpc/registry/local/DomainRegistry.java 94.26% <100.00%> (ø)

... and 5 files with indirect coverage changes

@Lo1nt Lo1nt requested review from OrezzerO and EvenLjj August 8, 2023 08:40
Copy link
Collaborator

@EvenLjj EvenLjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lo1nt Lo1nt merged commit 7177205 into sofastack:master Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants