support default filter config

[EvenLjj]

support default filter config

Summary by CodeRabbit

• New Features

  • Added default filter settings for RPC configurations to enhance flexibility and customization.
  • Introduced addFilter method to easily append filters in configurations.

• Tests

  • Added test cases to verify the functionality of adding filters in ConsumerConfig.

• Configuration

  • Updated JSON configuration files to include default filter implementations.

[coderabbitai]

Walkthrough

The update brings a new DEFAULT_FILTERS constant to RpcOptions, used in AbstractInterfaceConfig to set filters. It includes an addFilter method and corresponding tests. Configuration files and tests were adjusted to reflect these changes.

Changes

Files/Paths	Change Summary
.../RpcOptions.java	Added DEFAULT_FILTERS as a public static final String.
.../AbstractInterfaceConfig.java	- Imported getListValue and DEFAULT_FILTERS. - Initialized filter with DEFAULT_FILTERS. - Added addFilter method.
.../ConsumerConfigTest.java	Added testAddFilter() method for testing ConsumerConfig class.
.../FilterChainTest.java	Modified Arrays.asList usage for setting filters in ProviderConfig and ConsumerConfig. Removed import java.util.Arrays.
.../rpc-config.json	Added "default.filters": ["testChainFilter0", "-testChainFilter8"] to the existing configuration.
.../rpc-config-default.json	Added "default.filters": [] for default filter implementation in the JSON configuration file.

In code we trust, with filters anew,
A rabbit's touch, for tests to pursue.
Constants declared, configurations aligned,
With every change, our code refined.
Through JSON fields and methods bright,
We hop along, making it right.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 21acf28 and f5f409f.

Files selected for processing (6)

• core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1 hunks)
• core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java (3 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/config/ConsumerConfigTest.java (1 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java (2 hunks)
• core/api/src/test/resources/sofa-rpc/rpc-config.json (1 hunks)
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json (1 hunks)

Files skipped from review due to trivial changes (3)

• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java
• core/api/src/test/resources/sofa-rpc/rpc-config.json
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json

Additional comments not posted (4)

core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1)

125-128: LGTM! The addition of the DEFAULT_FILTERS constant aligns with the existing pattern of configuration options.

core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java (3)

45-47: New imports for getListValue and DEFAULT_FILTERS are correctly added.

---

111-111: The filter field is correctly initialized with getListValue(DEFAULT_FILTERS).

---

366-376: The addFilter method correctly handles adding filters to the filter field.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f5f409f and d316e98.

Files selected for processing (7)

• core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1 hunks)
• core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java (3 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/config/ConsumerConfigTest.java (1 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java (2 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/std/config/AbstractInterfaceConfigTest.java (1 hunks)
• core/api/src/test/resources/sofa-rpc/rpc-config.json (1 hunks)
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json (1 hunks)

Files not reviewed due to errors (1)

• core/api/src/test/java/com/alipay/sofa/rpc/std/config/AbstractInterfaceConfigTest.java (no review received)

Files skipped from review as they are similar to previous changes (6)

• core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java
• core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
• core/api/src/test/java/com/alipay/sofa/rpc/config/ConsumerConfigTest.java
• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java
• core/api/src/test/resources/sofa-rpc/rpc-config.json
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d316e98 and 6249b91.

Files selected for processing (6)

• core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java (1 hunks)
• core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java (3 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java (2 hunks)
• core/api/src/test/java/com/alipay/sofa/rpc/std/config/AbstractInterfaceConfigTest.java (2 hunks)
• core/api/src/test/resources/sofa-rpc/rpc-config.json (1 hunks)
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json (1 hunks)

Files skipped from review as they are similar to previous changes (6)

• core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java
• core/api/src/main/java/com/alipay/sofa/rpc/config/AbstractInterfaceConfig.java
• core/api/src/test/java/com/alipay/sofa/rpc/filter/FilterChainTest.java
• core/api/src/test/java/com/alipay/sofa/rpc/std/config/AbstractInterfaceConfigTest.java
• core/api/src/test/resources/sofa-rpc/rpc-config.json
• core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json

[chuailiwu]

lgtm