Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add providerProcessRegister event and record context to bolt #1417

Merged

Conversation

EvenLjj
Copy link
Collaborator

@EvenLjj EvenLjj commented May 21, 2024

add providerProcessRegister event and record context to bolt

Summary by CodeRabbit

  • New Features

    • Introduced event handling for registering and unregistering provider processors.
    • Added context information transfer from SofaRequest to RecordContext.
  • Enhancements

    • Updated dependency versions for improved stability and performance.
    • Improved event encapsulation for provider processor registration and unregistration.
  • Bug Fixes

    • Ensured proper context information is carried with requests in Bolt server processing.

@sofastack-cla sofastack-cla bot added cla:yes CLA is ok size/L labels May 21, 2024
Copy link
Contributor

coderabbitai bot commented May 21, 2024

Walkthrough

The recent updates focus on enhancing the SOFA RPC framework by upgrading dependency versions and introducing event handling for provider processors. Key changes include version updates in pom.xml files, new event classes for provider registration and unregistration, and context handling improvements in server processors. These changes aim to improve stability, traceability, and functionality within the SOFA RPC ecosystem.

Changes

File Path Change Summary
all/pom.xml Updated versions for sofa.common.tools and bolt dependencies.
bom/pom.xml Updated versions for sofa.common.tools and bolt dependencies.
bootstrap/bootstrap-api/src/main/java/com/.../DefaultProviderBootstrap.java Added event handling for registering and unregistering provider processors using EventBus.
core/api/src/main/java/com/.../RecordContextResolver.java Added carryWithRequest method to set context info from SofaRequest to RecordContext.
core/api/src/main/java/com/.../ProviderProcessorRegisterEvent.java Introduced ProviderProcessorRegisterEvent class for event handling during provider registration.
core/api/src/main/java/com/.../ProviderProcessorUnRegistryEvent.java Introduced ProviderProcessorUnRegistryEvent class for event handling during provider unregistration.
remoting/remoting-bolt/src/main/java/com/.../BoltServerProcessor.java Added import and method call to RecordContextResolver.carryWithRequest in handleRequest method.

🐇 A Rabbit's Code Poem 🐇

In the realm of code, where versions rise,
Dependencies grow and reach the skies.
Events now dance in a graceful ballet,
As processors register and then sway.
Contexts carry their tales with pride,
In SOFA's world, where changes abide.
🌟✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c7a45ea and 99fb4f5.
Files selected for processing (7)
  • all/pom.xml (1 hunks)
  • bom/pom.xml (1 hunks)
  • bootstrap/bootstrap-api/src/main/java/com/alipay/sofa/rpc/bootstrap/DefaultProviderBootstrap.java (3 hunks)
  • core/api/src/main/java/com/alipay/sofa/rpc/context/RecordContextResolver.java (1 hunks)
  • core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorRegisterEvent.java (1 hunks)
  • core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorUnRegistryEvent.java (1 hunks)
  • remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServerProcessor.java (2 hunks)
Files skipped from review due to trivial changes (3)
  • all/pom.xml
  • bom/pom.xml
  • core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorRegisterEvent.java
Additional comments not posted (4)
core/api/src/main/java/com/alipay/sofa/rpc/event/ProviderProcessorUnRegistryEvent.java (1)

26-43: The implementation of ProviderProcessorUnRegistryEvent class is correct and aligns with the PR objectives to handle provider processor un-registration events.

core/api/src/main/java/com/alipay/sofa/rpc/context/RecordContextResolver.java (1)

31-41: The carryWithRequest method correctly handles the transfer of context information from SofaRequest to RecordContext, aligning with the PR objectives for enhanced context management.

remoting/remoting-bolt/src/main/java/com/alipay/sofa/rpc/server/bolt/BoltServerProcessor.java (1)

215-215: The integration of RecordContextResolver.carryWithRequest in the handleRequest method is correctly implemented, ensuring that context information is appropriately managed and passed along within the bolt framework.

bootstrap/bootstrap-api/src/main/java/com/alipay/sofa/rpc/bootstrap/DefaultProviderBootstrap.java (1)

181-183: The addition of event handling in the doExport and unExport methods is correctly implemented. The use of EventBus.post for ProviderProcessorRegisterEvent and ProviderProcessorUnRegistryEvent aligns with the PR objectives to enhance event handling capabilities within the framework.

Also applies to: 315-317

Copy link
Collaborator

@chuailiwu chuailiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@EvenLjj EvenLjj merged commit 6b5f639 into sofastack:master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants