Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zookeeper registry get wrong provider list. (#166) #174

Merged
merged 7 commits into from
Jun 19, 2018

Conversation

JervyShi
Copy link
Member

Result:

Fixes #166

@JervyShi JervyShi requested a review from ujjboy June 13, 2018 12:58
@JervyShi JervyShi self-assigned this Jun 14, 2018
@JervyShi JervyShi added this to To do in v5.4.x via automation Jun 14, 2018
@JervyShi JervyShi added this to the 5.4.1 milestone Jun 14, 2018
@ujjboy ujjboy added the bug Something isn't working label Jun 15, 2018
@codecov-io
Copy link

codecov-io commented Jun 16, 2018

Codecov Report

Merging #174 into master will increase coverage by 0.26%.
The diff coverage is 74.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #174      +/-   ##
============================================
+ Coverage     70.99%   71.26%   +0.26%     
  Complexity      955      955              
============================================
  Files           341      341              
  Lines         14196    14210      +14     
  Branches       2281     2286       +5     
============================================
+ Hits          10079    10127      +48     
+ Misses         2939     2891      -48     
- Partials       1178     1192      +14
Impacted Files Coverage Δ Complexity Δ
.../java/com/alipay/sofa/rpc/common/RpcConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...ipay/sofa/rpc/client/SingleGroupAddressHolder.java 98.21% <100%> (+0.1%) 0 <0> (ø) ⬇️
...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java 59.37% <50%> (+2.28%) 0 <0> (ø) ⬇️
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java 70.17% <71.42%> (+1.65%) 0 <0> (ø) ⬇️
.../sofa/rpc/registry/zk/ZookeeperRegistryHelper.java 76.42% <73.52%> (+9.26%) 0 <0> (ø) ⬇️
...pay/sofa/rpc/transport/ClientTransportFactory.java 73.84% <0%> (-4.62%) 0% <0%> (ø)
.../main/java/com/alipay/sofa/rpc/tracer/Tracers.java 39.74% <0%> (-2.57%) 0% <0%> (ø)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 83.92% <0%> (-1.79%) 0% <0%> (ø)
...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java 66.49% <0%> (+2.53%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e63253...4ade313. Read the comment docs.

* @param <T> 值类型
* @return 返回值
*/
protected <T> T delayGet(Callable<T> callable, T expect, int period, int times) {
Copy link
Member

@ujjboy ujjboy Jun 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this method because I add TestUtils.java at #180 contains this method. Just use TestUtils.delayGet() instead of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have fixed it.

@ujjboy ujjboy merged commit e5fdd06 into sofastack:master Jun 19, 2018
v5.4.x automation moved this from To do to Done Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v5.4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants