Add support for http2 prior knowledge mode. (#164) #179

jjtyro · 2018-06-14T04:51:27Z

Fixes #164

Add some code for http transport to support http2 Prior-Knowledge mode connection.

jjtyro · 2018-06-14T05:09:45Z

What means :
"[0K$ sh ./tools/check_format.sh
Please commit your change before run this shell, un commit files:
M extension-impl/remoting-http/src/main/java/com/alipay/sofa/rpc/transport/http/Http2ClientInitializer.java"
It have been commit in branch at my side

JervyShi · 2018-06-14T05:22:20Z

@jjtyro See Contributing , you could run mvn clean compile to make sure your changes have been formated.

jjtyro · 2018-06-14T05:36:36Z

@JervyShi OhOhOh, I ran 'mvn clean compile' and then I saw one line of code changed and I deleted the extra space.

jjtyro · 2018-06-14T05:47:22Z

@JervyShi oraclejdk8 and openjdk6 successed. openjdk7 failed? why?

JervyShi · 2018-06-14T05:58:09Z

@jjtyro You can figure it out or just retry.

leizhiyuan · 2018-06-14T06:12:57Z

I run jdk7 again

codecov-io · 2018-06-14T06:20:38Z

Codecov Report

Merging #179 into master will increase coverage by 0.12%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master     #179      +/-   ##
============================================
+ Coverage     68.89%   69.02%   +0.12%     
- Complexity      951      955       +4     
============================================
  Files           341      341              
  Lines         14183    14194      +11     
  Branches       2276     2278       +2     
============================================
+ Hits           9772     9797      +25     
+ Misses         3241     3232       -9     
+ Partials       1170     1165       -5

Impacted Files	Coverage Δ	Complexity Δ
...in/java/com/alipay/sofa/rpc/common/RpcOptions.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ofa/rpc/transport/http/Http2ClientInitializer.java	`73.77% <91.66%> (+3.77%)`	`8 <2> (+2)`	⬆️
...pay/sofa/rpc/transport/ClientTransportFactory.java	`73.84% <0%> (-3.08%)`	`0% <0%> (ø)`
...ay/sofa/rpc/client/AllConnectConnectionHolder.java	`63.12% <0%> (+0.27%)`	`0% <0%> (ø)`	⬇️
.../alipay/sofa/rpc/registry/local/LocalRegistry.java	`57.83% <0%> (+0.6%)`	`26% <0%> (+1%)`	⬆️
.../rpc/transport/http/Http2ServerChannelHandler.java	`75.63% <0%> (+0.84%)`	`25% <0%> (+1%)`	⬆️
...ava/com/alipay/sofa/rpc/config/RegistryConfig.java	`36% <0%> (+1%)`	`0% <0%> (ø)`	⬇️
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java	`90.24% <0%> (+1.21%)`	`0% <0%> (ø)`	⬇️
...ofa/rpc/registry/zk/ZookeeperOverrideObserver.java	`15.27% <0%> (+1.38%)`	`0% <0%> (ø)`	⬇️
...ofa/rpc/registry/zk/ZookeeperProviderObserver.java	`68.51% <0%> (+1.85%)`	`0% <0%> (ø)`	⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53569c0...6b50362. Read the comment docs.

ujjboy · 2018-06-14T07:04:47Z

core/api/src/main/java/com/alipay/sofa/rpc/common/RpcOptions.java

+    /**
+     * Whether the Http2 Cleartext protocol client uses Prior Knowledge to start Http2
+     */
+    public static final String TRANSPORT_H2C_USE_PRIOR_KNOWLEDGE  = "transport.h2c.use_prior_knowledge";


change to transport.client.h2c.usePriorKnowledge

ujjboy · 2018-06-14T07:05:23Z

core/common/src/main/resources/com/alipay/sofa/rpc/common/rpc-config-default.json

@@ -258,6 +258,8 @@ PS:大家也看到了，本JSON文档是支持注释的，而标准JSON是不支
  "compress.open": false,
  // 开启压缩的大小基线
  "compress.size.baseline": 2048,
+  //Whether the Http2 Cleartext protocol client uses Prior Knowledge to start Http2
+  "transport.h2c.use_prior_knowledge": false,


default value can set to true.

Set false to keep the original default behavior of using upgrade h2c

It 's ok to set true because we know exactly the protocol of provider is h2c.

Ok, I changed it to true.

ujjboy · 2018-06-14T07:06:17Z

...l/remoting-http/src/main/java/com/alipay/sofa/rpc/transport/http/Http2ClientInitializer.java

@@ -74,7 +83,11 @@ public void initChannel(SocketChannel ch) throws Exception {
        if (RpcConstants.PROTOCOL_TYPE_H2.equals(protocol)) {
            configureSsl(ch);
        } else if (RpcConstants.PROTOCOL_TYPE_H2C.equals(protocol)) {
-            configureClearText(ch);
+            if (!useH2cPriorKnowledge) {
+                configureClearText(ch);


configureClearTextWithHttpUgrade()

Ok. I will modify it.

ujjboy · 2018-06-14T07:06:29Z

...l/remoting-http/src/main/java/com/alipay/sofa/rpc/transport/http/Http2ClientInitializer.java

+            if (!useH2cPriorKnowledge) {
+                configureClearText(ch);
+            } else {
+                configureClearTextPriorKnowledge(ch);


configureClearTextWithPriorKnowledge()

Ok. I will modify it.

ujjboy · 2018-06-14T07:07:19Z

...l/remoting-http/src/main/java/com/alipay/sofa/rpc/transport/http/Http2ClientInitializer.java

+    private static class PrefaceFrameWrittenEventHandler extends ChannelInboundHandlerAdapter {
+        @Override
+        public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception {
+            System.out.println("User Event Handler :" + evt.toString());


Use LOGGER instead of System.out.println

ah, it is learned from previous code's UserEventLogger, I will change it

ujjboy · 2018-06-14T09:34:02Z

...egration/src/test/java/com/alipay/sofa/rpc/transport/http/Http2ClearTextHttpUpgradeTest.java

+        RpcConfigs.putValue("transport.client.h2c.usePriorKnowledge", false);
+        ActivelyDestroyTest.adBeforeClass();
+    }
+


Should add @AfterClass method for reset default value of transport.client.h2c.usePriorKnowledge, and use RpcOptions.TRANSPORT_CLIENT_H2C_USE_PRIOR_KNOWLEDGE

…_USE_PRIOR_KNOWLEDGE in Test code

add support for http2 prior knownledge mode

4ba4471

ujjboy added the optimization Code optimization label Jun 14, 2018

ujjboy added this to the 5.4.1 milestone Jun 14, 2018

ujjboy added this to To do in v5.4.x via automation Jun 14, 2018

modify some import * to import concrete class and format code

69ef792

ujjboy requested changes Jun 14, 2018

View reviewed changes

sofastack deleted a comment from khotyn Jun 14, 2018

Change some properties and method name for name style

1bc47c9

ujjboy reviewed Jun 14, 2018

View reviewed changes

jjtyro added 2 commits June 15, 2018 09:45

add restore vaule of config parameter RpcOptions.TRANSPORT_CLIENT_H2C…

a9256c6

…_USE_PRIOR_KNOWLEDGE in Test code

Merge branch 'master' into add_support_http2_prior_knowledge_feature

6b50362

ujjboy approved these changes Jun 15, 2018

View reviewed changes

ujjboy merged commit 3a0b068 into sofastack:master Jun 15, 2018

v5.4.x automation moved this from To do to Done Jun 15, 2018

ujjboy changed the title ~~add support for http2 prior knownledge mode (#164)~~ Add support for http2 prior knowledge mode. (#164) Jun 15, 2018

jjtyro deleted the add_support_http2_prior_knowledge_feature branch June 15, 2018 02:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for http2 prior knowledge mode. (#164) #179

Add support for http2 prior knowledge mode. (#164) #179

jjtyro commented Jun 14, 2018

jjtyro commented Jun 14, 2018

JervyShi commented Jun 14, 2018

jjtyro commented Jun 14, 2018

jjtyro commented Jun 14, 2018

JervyShi commented Jun 14, 2018

leizhiyuan commented Jun 14, 2018

codecov-io commented Jun 14, 2018 •

edited

Loading

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018

jjtyro Jun 14, 2018

ujjboy Jun 14, 2018 •

edited

Loading

jjtyro Jun 15, 2018

Add support for http2 prior knowledge mode. (#164) #179

Add support for http2 prior knowledge mode. (#164) #179

Conversation

jjtyro commented Jun 14, 2018

jjtyro commented Jun 14, 2018

JervyShi commented Jun 14, 2018

jjtyro commented Jun 14, 2018

jjtyro commented Jun 14, 2018

JervyShi commented Jun 14, 2018

leizhiyuan commented Jun 14, 2018

codecov-io commented Jun 14, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ujjboy Jun 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Jun 14, 2018 •

edited

Loading

ujjboy Jun 14, 2018 •

edited

Loading