Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support protobuf serialization in the env of multiple class loader. #49

Merged
merged 3 commits into from
Apr 28, 2018

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented Apr 24, 2018

#48

@ujjboy ujjboy added the enhancement New feature or request label Apr 24, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone Apr 24, 2018
@ujjboy ujjboy added this to To do in v5.4.x via automation Apr 24, 2018
@codecov-io
Copy link

codecov-io commented Apr 24, 2018

Codecov Report

Merging #49 into master will increase coverage by 0.05%.
The diff coverage is 62.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
+ Coverage     63.49%   63.54%   +0.05%     
- Complexity      585      593       +8     
============================================
  Files           263      263              
  Lines         11226    11272      +46     
  Branches       1871     1884      +13     
============================================
+ Hits           7128     7163      +35     
- Misses         3133     3140       +7     
- Partials        965      969       +4
Impacted Files Coverage Δ Complexity Δ
...ipay/sofa/rpc/codec/bolt/SofaRpcSerialization.java 47.02% <0%> (-0.37%) 36 <0> (ø)
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 79.43% <100%> (+3.59%) 0 <0> (ø) ⬇️
...lipay/sofa/rpc/codec/antpb/ProtobufSerializer.java 53.84% <63.26%> (+6.02%) 17 <11> (+8) ⬆️
...ent/aft/impl/ServiceHorizontalMeasureStrategy.java 83.65% <0%> (-2.89%) 22% <0%> (-1%)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 83.92% <0%> (-1.79%) 0% <0%> (ø)
...pay/sofa/rpc/client/aft/InvocationStatFactory.java 87.8% <0%> (+4.87%) 16% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58c85a5...c3d53f8. Read the comment docs.

@ujjboy ujjboy merged commit f0ad19f into sofastack:master Apr 28, 2018
v5.4.x automation moved this from To do to Done Apr 28, 2018
@ujjboy ujjboy deleted the support_mcl branch April 28, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v5.4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants