Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not close connection by url when connection closed. #498

Merged
merged 6 commits into from Feb 20, 2019
Merged

Do not close connection by url when connection closed. #498

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28b7215
do not close connection with connection.close
leizhiyuan Jan 28, 2019
4050ad3
Merge branch 'master' into fix_bolt_connection_bug
leizhiyuan Feb 14, 2019
512ea5b
Merge branch 'master' into fix_bolt_connection_bug
leizhiyuan Feb 19, 2019
691fcc0
Merge branch 'master' into fix_bolt_connection_bug
leizhiyuan Feb 20, 2019
cb1b05f
Merge branch 'master' into fix_bolt_connection_bug
leizhiyuan Feb 20, 2019
3211444
Merge branch 'master' into fix_bolt_connection_bug
leizhiyuan Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ng-bolt/src/main/java/com/alipay/sofa/rpc/transport/bolt/BoltClientConnectionManager.java
View file
Open in desktop
Expand Up @@ -126,7 +126,7 @@ public Connection getConnection(RpcClient rpcClient, ClientTransportConfig trans
if (LOGGER.isWarnEnabled()) {
LOGGER.warn("Multiple threads init ClientTransport with same key:" + url);
}
connection.close(); //如果同时有人插入，则使用第一个
rpcClient.closeStandaloneConnection(connection); //如果同时有人插入，则使用第一个
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closeStandaloneConnection 对应的是 RpcClient#createStandaloneConnection 创建出的连接。我们这里用的是 RpcClient#getConnection 这个应该是自带 connectionManager 的。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，自带，我们这个是为了修复那个bug。

connection = oldConnection;
} else {

Expand Down Expand Up @@ -188,7 +188,7 @@ public void closeConnection(RpcClient rpcClient, ClientTransportConfig transport
}
}
if (needDestroy) {
rpcClient.closeConnection(url);
rpcClient.closeStandaloneConnection(connection);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

}
}
}