Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo, SofaRegsitryClient -> SofaRegistryClient #581

Merged
merged 1 commit into from
Apr 12, 2019

Conversation

dulong
Copy link
Contributor

@dulong dulong commented Apr 12, 2019

Motivation:

fix typo

Modification:

SofaRegsitryClient -> SofaRegistryClient

Result:

Fixes #580.

@ujjboy ujjboy added this to the 5.6.0 milestone Apr 12, 2019
@ujjboy ujjboy added this to To do in 5.6.x via automation Apr 12, 2019
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #581 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #581      +/-   ##
============================================
+ Coverage     71.11%   71.15%   +0.04%     
- Complexity     1145     1149       +4     
============================================
  Files           377      377              
  Lines         15774    15774              
  Branches       2550     2550              
============================================
+ Hits          11217    11224       +7     
+ Misses         3220     3210      -10     
- Partials       1337     1340       +3
Impacted Files Coverage Δ Complexity Δ
...pay/sofa/rpc/transport/ClientTransportFactory.java 72.3% <0%> (-4.62%) 0% <0%> (ø)
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 91.93% <0%> (+1.61%) 0% <0%> (ø) ⬇️
...fa/rpc/registry/consul/model/HeartbeatService.java 32.35% <0%> (+2.94%) 5% <0%> (+1%) ⬆️
...fa/rpc/registry/consul/internal/ConsulManager.java 51% <0%> (+5%) 13% <0%> (+2%) ⬆️
...ofa/rpc/registry/consul/internal/TtlScheduler.java 83.33% <0%> (+5.55%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7825d1...06e868d. Read the comment docs.

5.6.x automation moved this from To do to In Progress Apr 12, 2019
@JervyShi JervyShi merged commit 1230c2a into sofastack:master Apr 12, 2019
5.6.x automation moved this from In Progress to Done Apr 12, 2019
@khotyn
Copy link
Member

khotyn commented Apr 12, 2019

@dulong Thanks for your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
5.6.x
  
Done
Development

Successfully merging this pull request may close these issues.

fix typo, SofaRegsitryClient -> SofaRegistryClient
5 participants