Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default connection timeout 1000ms #777

Merged
merged 1 commit into from Oct 8, 2019
Merged

change default connection timeout 1000ms #777

merged 1 commit into from Oct 8, 2019

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes ##776

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan added this to the 5.5.9 milestone Sep 27, 2019
@codecov-io
Copy link

Codecov Report

Merging #777 into 5.5 will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                5.5     #777      +/-   ##
============================================
- Coverage     70.73%   70.61%   -0.13%     
+ Complexity     1152     1147       -5     
============================================
  Files           386      386              
  Lines         16062    16058       -4     
  Branches       2589     2584       -5     
============================================
- Hits          11362    11339      -23     
- Misses         3350     3369      +19     
  Partials       1350     1350
Impacted Files Coverage Δ Complexity Δ
...java/com/alipay/sofa/rpc/module/LookoutModule.java 52.38% <0%> (-33.34%) 3% <0%> (-1%)
...ofa/rpc/registry/consul/internal/TtlScheduler.java 77.77% <0%> (-5.56%) 7% <0%> (-1%)
...fa/rpc/registry/consul/internal/ConsulManager.java 46% <0%> (-5%) 11% <0%> (-2%)
...alipay/sofa/rpc/api/context/RpcContextManager.java 47.82% <0%> (-4.35%) 4% <0%> (ø)
...fa/rpc/registry/consul/model/HeartbeatService.java 29.41% <0%> (-2.95%) 4% <0%> (-1%)
...m/alipay/sofa/rpc/codec/jackson/JacksonHelper.java 77.77% <0%> (-2.78%) 7% <0%> (-1%)
...ofa/rpc/registry/zk/ZookeeperOverrideObserver.java 39.34% <0%> (-1.64%) 0% <0%> (ø)
.../sofa/rpc/bootstrap/DefaultClientProxyInvoker.java 90.32% <0%> (-1.62%) 0% <0%> (ø)
.../java/com/alipay/sofa/rpc/ext/ExtensionLoader.java 79.6% <0%> (-0.5%) 0% <0%> (ø)
...om/alipay/sofa/rpc/metrics/lookout/RpcLookout.java 75.23% <0%> (-0.24%) 14% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d15f8a...8c9aba9. Read the comment docs.

@leizhiyuan leizhiyuan merged commit 7a13b00 into sofastack:5.5 Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants