Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix npe of AbstractCluster #795

Merged
merged 1 commit into from
Nov 6, 2019
Merged

bugfix:fix npe of AbstractCluster #795

merged 1 commit into from
Nov 6, 2019

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes ##724

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes CLA is ok size/XS labels Nov 6, 2019
@leizhiyuan leizhiyuan added this to the 5.6.3 milestone Nov 6, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@201de55). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #795   +/-   ##
=========================================
  Coverage          ?   71.83%           
  Complexity        ?     1078           
=========================================
  Files             ?      376           
  Lines             ?    15344           
  Branches          ?     2442           
=========================================
  Hits              ?    11023           
  Misses            ?     3054           
  Partials          ?     1267
Impacted Files Coverage Δ Complexity Δ
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 66.77% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201de55...71fc6e0. Read the comment docs.

@leizhiyuan leizhiyuan merged commit f533fd9 into sofastack:master Nov 6, 2019
@leizhiyuan leizhiyuan deleted the fix_npe branch November 6, 2019 04:38
@khotyn
Copy link
Member

khotyn commented Nov 6, 2019

@leizhiyuan You should ask someone else to review your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes CLA is ok size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants