Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add custom parameter to values #800

Merged
merged 1 commit into from
Nov 17, 2019
Merged

feat:add custom parameter to values #800

merged 1 commit into from
Nov 17, 2019

Conversation

leizhiyuan
Copy link
Contributor

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@leizhiyuan leizhiyuan added this to the 5.6.3 milestone Nov 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #800 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #800     +/-   ##
===========================================
- Coverage     72.02%   71.93%   -0.1%     
+ Complexity     1083     1080      -3     
===========================================
  Files           376      376             
  Lines         15344    15345      +1     
  Branches       2442     2442             
===========================================
- Hits          11052    11038     -14     
- Misses         3032     3040      +8     
- Partials       1260     1267      +7
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/registry/local/LocalRegistryHelper.java 65.67% <100%> (+0.25%) 20 <0> (ø) ⬇️
...ipay/sofa/rpc/server/bolt/BoltServerProcessor.java 64.92% <0%> (-5.23%) 24% <0%> (-3%)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 80.35% <0%> (-1.79%) 0% <0%> (ø)
...pay/sofa/rpc/transport/ClientTransportFactory.java 76.92% <0%> (-1.54%) 0% <0%> (ø)
...com/alipay/sofa/rpc/context/RpcRuntimeContext.java 88.88% <0%> (-1.24%) 0% <0%> (ø)
...ipay/sofa/rpc/tracer/sofatracer/RpcSofaTracer.java 88.85% <0%> (-0.91%) 0% <0%> (ø)
...va/com/alipay/sofa/rpc/client/AbstractCluster.java 66.14% <0%> (-0.63%) 0% <0%> (ø)
...alipay/sofa/rpc/registry/zk/ZookeeperRegistry.java 62.65% <0%> (-0.61%) 0% <0%> (ø)
.../java/com/alipay/sofa/rpc/client/ProviderInfo.java 71.96% <0%> (+1.86%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f533fd9...4ffde27. Read the comment docs.

Copy link
Member

@JervyShi JervyShi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjboy ujjboy merged commit c01864b into sofastack:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants