Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:optimize the exception code #829

Merged
merged 1 commit into from
Dec 23, 2019
Merged

chore:optimize the exception code #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/api/src/main/java/com/alipay/sofa/rpc/log/LoggerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ public static Logger getLogger(String name) {
} else {
throw new SofaRpcRuntimeException(implClass + " is not type of " + Logger.class);
}
} catch (SofaRpcRuntimeException ex) {
throw ex;
} catch (Exception e) {
throw new SofaRpcRuntimeException("Error when getLogger of " + name
+ ", implement is " + implClass + "", e);
Expand All @@ -58,6 +60,8 @@ public static Logger getLogger(Class clazz) {
} else {
throw new SofaRpcRuntimeException(implClass + " is not type of " + Logger.class);
}
} catch (SofaRpcRuntimeException ex) {
throw ex;
} catch (Exception e) {
throw new SofaRpcRuntimeException("Error when getLogger of " + clazz.getName()
+ ", implement is " + implClass + "", e);
Expand Down