Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default bootstrap to sofa. #94

Merged
merged 1 commit into from
May 5, 2018
Merged

Conversation

ujjboy
Copy link
Member

@ujjboy ujjboy commented May 5, 2018

Fix #90

@ujjboy ujjboy added the enhancement New feature or request label May 5, 2018
@ujjboy ujjboy added this to the 5.4.0 milestone May 5, 2018
@ujjboy ujjboy added this to To do in v5.4.x via automation May 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #94 into master will decrease coverage by 0.05%.
The diff coverage is 80.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     63.93%   63.87%   -0.06%     
- Complexity      595      603       +8     
============================================
  Files           263      265       +2     
  Lines         11304    11333      +29     
  Branches       1892     1897       +5     
============================================
+ Hits           7227     7239      +12     
- Misses         3103     3122      +19     
+ Partials        974      972       -2
Impacted Files Coverage Δ Complexity Δ
...y/sofa/rpc/bootstrap/DefaultProviderBootstrap.java 60.91% <ø> (ø) 0 <0> (ø) ⬇️
...m/alipay/sofa/rpc/bootstrap/ConsumerBootstrap.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...a/com/alipay/sofa/rpc/codec/SerializerFactory.java 91.66% <ø> (ø) 0 <0> (ø) ⬇️
...y/sofa/rpc/bootstrap/DefaultConsumerBootstrap.java 68.51% <ø> (-0.43%) 0 <0> (ø)
...ava/com/alipay/sofa/rpc/config/ConsumerConfig.java 70.51% <ø> (-0.19%) 0 <0> (ø)
.../com/alipay/sofa/rpc/protocol/ProtocolFactory.java 62.96% <ø> (ø) 0 <0> (ø) ⬇️
...ava/com/alipay/sofa/rpc/config/ProviderConfig.java 51.57% <ø> (-0.51%) 0 <0> (ø)
...sofa/rpc/bootstrap/bolt/BoltConsumerBootstrap.java 100% <100%> (ø) 2 <1> (+1) ⬆️
...sofa/rpc/bootstrap/rest/RestConsumerBootstrap.java 100% <100%> (ø) 2 <1> (+1) ⬆️
...java/com/alipay/sofa/rpc/bootstrap/Bootstraps.java 95.65% <100%> (+9.93%) 0 <0> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8aab8...2ff07fb. Read the comment docs.

@ujjboy ujjboy merged commit 98b5ec4 into sofastack:master May 5, 2018
v5.4.x automation moved this from To do to Done May 5, 2018
@ujjboy ujjboy deleted the fix_issue_90 branch May 5, 2018 17:45
@ujjboy ujjboy mentioned this pull request May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v5.4.x
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants