Fix OkHttpTracer don't send log to Zipkin bug #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glmapper
approved these changes
Feb 22, 2019
leizhiyuan
pushed a commit
that referenced
this pull request
Apr 7, 2019
* 1、升级zipkin版本值最新版本，ui支持中文；2、修复模型转换中的一些bug，去除对RPC类型的特殊处理逻辑；3、修复Endpoint计算逻辑；4、对于zipkin中的serviceName赋值，使用按服务节点作为serviceName，不在依赖span的oparetionName * rename zipkin's base package name to com.alipay.sofa.tracer.plugins.zipkin * glmapper-branch-3.x-sheery-pick * rename zipkin's base package name to com.alipay.sofa.tracer.plugins.zipkin * cheery pick okhttp * Fix OkHttpTracer don't send log to Zipkin bug #173 (#173) (cherry picked from commit f728346) * compile&code format * cheery pick datasource * cheery pick datasource * cherry pick * okhttp * up version 3.0.3 for sampler * up version 3.0.3 for sampler * code format * sheery pick * 移除采样参数设置 * rebuild * prepare to release 3.0.3 * prepare to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When I test OkHttp plugin with Zipkin,I found that Zipkin don't find the remote call of OkHttp.
Modification:
SofaTracerOkHttpInterceptor will call clientReceive method when OkHttp get the response.
Result:
Zipkin can find the remote call of OkHttp.
Fixes #174