Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized server received logic #289

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

glmapper
Copy link
Contributor

when in the sr stage, a new span should be built by the SofaTracer instance.

At present, we construct spanContext and Span directly through the constructor, which adds complexity to the span relationship. The API provided in SofaTracerSpanBuilder solves this problem.

Copy link
Contributor

@xzchaoo xzchaoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@guanchao-yang guanchao-yang merged commit de8ded5 into sofastack:3.x Nov 6, 2019
@glmapper glmapper deleted the fix-server-spancontext branch November 6, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants