Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov upgrade #423

Merged
merged 10 commits into from
Feb 24, 2021
Merged

Codecov upgrade #423

merged 10 commits into from
Feb 24, 2021

Conversation

glmapper
Copy link
Contributor

No description provided.

@sofastack-bot sofastack-bot bot added size/M and removed size/S labels Feb 20, 2021
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Feb 20, 2021
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@703c99a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage          ?   44.86%           
  Complexity        ?      224           
=========================================
  Files             ?      287           
  Lines             ?     9480           
  Branches          ?      936           
=========================================
  Hits              ?     4253           
  Misses            ?     4743           
  Partials          ?      484

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c99a...88d8644. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@703c99a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage          ?   44.67%           
  Complexity        ?      224           
=========================================
  Files             ?      287           
  Lines             ?     9480           
  Branches          ?      936           
=========================================
  Hits              ?     4235           
  Misses            ?     4763           
  Partials          ?      482

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 703c99a...88d8644. Read the comment docs.

@khotyn
Copy link
Member

khotyn commented Feb 23, 2021

When this PR will be merged?

@glmapper
Copy link
Contributor Author

When this PR will be merged?

Yes

@glmapper glmapper requested a review from khotyn February 23, 2021 12:29
ujjboy
ujjboy approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@ujjboy ujjboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

khotyn
khotyn requested changes Feb 23, 2021
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@khotyn khotyn merged commit 1ec4c8d into sofastack:master Feb 24, 2021
@khotyn
Copy link
Member

khotyn commented Feb 24, 2021

image
@glmapper Click on the CodeCov report, got the page above, it seems that there is something wrong with our coverage setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khotyn khotyn khotyn approved these changes

@ujjboy ujjboy ujjboy approved these changes

@alaneuler alaneuler Awaiting requested review from alaneuler

Assignees
No one assigned
Labels
cla:yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glmapper @codecov-io @khotyn @ujjboy