Sofa ark 启动过程源码解析 #965
Merged
Sofa ark 启动过程源码解析 #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lijunf, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
|
@yuanyuancin Please review this PR. |
lijunf
force-pushed
the
master
branch
2 times, most recently
from
cce336f
to
3d30eaa
Compare
|
@yuanyuancin Please review |
yuanyuancin
reviewed
Aug 15, 2022
There was a problem hiding this comment.
- 方法体为 ... 省略的方法、不重要的方法代码 建议删除，缩小篇幅，可以稍微减少一些代码片段
- “在 SOFAArk 2.0 中采用 spring-boot 原生打包插件 spring-boot-maven-plugin 打包”，2.0只有基座是改为原生打包插件，模块仍旧是sofa-ark-maven-plugin
- “并且 master biz 是使用 Launcher$AppClassLoader 加载的”，不一定的，本地启动是AppClassLoader，服务器启动是spring的LaunchedURLClassLoader
yuanyuancin
reviewed
Aug 15, 2022
|
@yuanyuancin 看一下这个commit，56c9eb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sofastack/sofa-ark#505