Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade for Xcode 10 and Swift 4.2 #41

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Upgrade for Xcode 10 and Swift 4.2 #41

merged 1 commit into from
Jan 2, 2019

Conversation

guykogus
Copy link
Contributor

This mainly just removes warnings in Xcode 10.

@guykogus
Copy link
Contributor Author

@soffes any chance to review this PR?

@soffes soffes merged commit e329cea into soffes:master Jan 2, 2019
@soffes
Copy link
Owner

soffes commented Jan 2, 2019

Thanks for doing this! Sorry for the delay!

1 similar comment
@soffes
Copy link
Owner

soffes commented Jan 2, 2019

Thanks for doing this! Sorry for the delay!

@guykogus guykogus deleted the xcode-10_swift-4.2 branch January 2, 2019 07:31
@andrew-nemtsev
Copy link

Whether these changes will be available via cocoapods?
Current available pod 2.3.3 is not compile with xCode 10.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guykogus @soffes @andrew-nemtsev