Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Renaming SSKeychainQuery's method from delete: to deleteItem: should have been done by bumping the MAJOR version of the library #57

Closed
peymano opened this issue Jan 29, 2014 · 1 comment
Closed

Renaming SSKeychainQuery's method from delete: to deleteItem: should have been done by bumping the MAJOR version of the library #57

peymano opened this issue Jan 29, 2014 · 1 comment

Comments

@peymano
Copy link

peymano commented Jan 29, 2014

Commit 9677aae renamed the method, but only the minor version number was bumped. This violates semantic versioning because this is an incompatible API change. (Cocoapods are expected to follow semantic versioning.)

This change is insidious because the compiler wont flag calls to delete:—UIResponder adds delete: to NSObject via a class category, but doesn't provide a default implement there.

FYI @soffes
@soffes
Copy link
Owner

soffes commented Jun 19, 2015

Sorry for the oversight.

@soffes soffes closed this as completed Jun 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peymano @soffes