Renaming SSKeychainQuery's method from `delete:` to `deleteItem:` should have been done by bumping the MAJOR version of the library #57

Closed
peymano opened this Issue Jan 29, 2014 · 1 comment

Comments

Projects
None yet
2 participants

peymano commented Jan 29, 2014

Commit 9677aae renamed the method, but only the minor version number was bumped. This violates semantic versioning because this is an incompatible API change. (Cocoapods are expected to follow semantic versioning.)

This change is insidious because the compiler wont flag calls to delete:UIResponder adds delete: to NSObject via a class category, but doesn't provide a default implement there.

FYI @soffes

Owner

soffes commented Jun 19, 2015

Sorry for the oversight.

soffes closed this Jun 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment