Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact Report Demo for "TEST: Retry synced-flush if ongoing ops on primary" #2

Closed
wants to merge 6 commits into from

Conversation

JoeNguyen93
Copy link

@JoeNguyen93 JoeNguyen93 commented Jun 5, 2018

This is example PR to demonstrate Softagram Impact reports, Original PR here: elastic#30978

When the last indexing operation is completed, we will fire a global
checkpoint sync.  Since a global checkpoint sync request is a
replication request, it will acquire an index shard permit on the
primary when executing.  If this happens at the same time while we are
issuing the synced-flush, the synced-flush request will fail as it
thinks there are in-flight operations. We can avoid such situation by
not issue the synced-flush until the global checkpoint on the primary is
propagated to replicas.
@JoeNguyen93 JoeNguyen93 changed the title Test PR 30978 TEST: Retry synced-flush if ongoing ops on primary Jun 5, 2018
@JoeNguyen93 JoeNguyen93 changed the title TEST: Retry synced-flush if ongoing ops on primary Impact Report Demo for "TEST: Retry synced-flush if ongoing ops on primary" Jun 5, 2018
@softagram-bot
Copy link

Softagram Impact Report for pull/2

⭐ Visual Overview

Changed elements and changed dependencies.
Changed dependencies - click for full size
Graph legend
(Open in Softagram Desktop for full details)

⭐ Change Impact

How the changed files are used by the rest of the project
Impacted files - click for full size
Graph legend
(Open in Softagram Desktop for full details)

📄 Full report

Give feedback of this report to support@softagram.com

@softagram softagram deleted a comment from makimat Jun 5, 2018
@softagram softagram deleted a comment from makimat Jun 5, 2018
@JoeNguyen93 JoeNguyen93 closed this Jun 7, 2018
@JoeNguyen93 JoeNguyen93 deleted the pull-30978 branch June 7, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants