Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doc section for third party tools #451

Merged
merged 1 commit into from
May 13, 2024

Conversation

ratmice
Copy link
Collaborator

@ratmice ratmice commented May 13, 2024

It was recommended in #448 to add a link to the book about nimbleparse_lsp.
I'm not really certain it is a good idea to advertise it yet, as it has fallen behind by a few releases and overall is still fairly
prototype quality.

Despite that, this adds "third party" section in chapter 6 of "individual libraries and tools".
I had hoped to just link directly to the repository, relying on the external readme.

Unfortunately trying to link to a [lsp](https://) within SUMMARY.md appends a .html extension breaking the URL.
Between adding a subsection, or just embedding a list within the thirdparty.md I went with a subsection,
since it more closely mirrored how the current list of tools and libraries is listed.

@ltratt
Copy link
Member

ltratt commented May 13, 2024

Can we fold this into a single thirdparty.md file? I don't think we need a page per tool, but I agree that linking to nimbleparse_lsp from the book is a good idea.

@ratmice
Copy link
Collaborator Author

ratmice commented May 13, 2024

Sure, I went ahead and did that. It means we don't get a link directly in the table of contents, but it seems more maintainable to just link directly to each project anyways instead of relying on potentially dated generic summary.

@ltratt
Copy link
Member

ltratt commented May 13, 2024

Thanks! Please squash.

@ratmice
Copy link
Collaborator Author

ratmice commented May 13, 2024

Squashed (with a minor grammar fix).

@ltratt ltratt added this pull request to the merge queue May 13, 2024
Merged via the queue into softdevteam:master with commit b4d2b98 May 13, 2024
2 checks passed
@ratmice ratmice deleted the third_party_tools branch May 13, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants