Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactorings of commonly used dictionaries #75

Closed
snim2 opened this issue Oct 27, 2015 · 3 comments
Closed

Minor refactorings of commonly used dictionaries #75

snim2 opened this issue Oct 27, 2015 · 3 comments

Comments

@snim2
Copy link
Collaborator

snim2 commented Oct 27, 2015

This is from the discussion on PR #74

Data from krun configuration files (and results files) is loaded when krun.py starts, and are used in various parts of the code. Usually parts of the configuration (such as filenames) are passed around as separate variables. It would be neater to factor these out into classes, so that a single object can be passed around (and tested).

@snim2
Copy link
Collaborator Author

snim2 commented Oct 27, 2015

Under this scheme, the krun.util.audits_same_platform should become a method.

@snim2
Copy link
Collaborator Author

snim2 commented Nov 2, 2015

In which case, this might be useful for the same-platform check:

http://stackoverflow.com/questions/328936/getting-a-unique-id-from-a-unix-like-system

@ltratt
Copy link
Member

ltratt commented Nov 2, 2015

I still think hostname is an adequate proxy. There isn't a single method which is guaranteed to work, so let's stick with the simplest possible scheme. If it goes wrong, at least people will be able to understand why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants