Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6 add initial api specification #11

Merged
merged 13 commits into from
Jun 8, 2021

Conversation

softgitron
Copy link
Owner

Short summary of changes in this pull request:
This pull request provides main core and module API definitions in OpenAPI format. OpenAPI format is very useful, since it enables automatic checking of incoming API calls and provides a way to generate documentation of the API automatically.

Short summary of important/debatable decisions and other notable choices made when working on the pull request:
OpenAPI was selected as a language for defining APIs in potku-console.

Other relevant information:
This is very big and important feature. API can be partly altered in the future, but it will be increasingly harder when code base grows. Because of that all discussion is especially welcome related to this PR.

@softgitron
Copy link
Owner Author

softgitron commented May 22, 2021

First full core API draft is now available. Please review it. OpenAPI editor can be used for easier visual inspection of the specification.

@softgitron
Copy link
Owner Author

First full core API draft is now available. Please review it. OpenAPI editor can be used for easier visual inspection of the specification.

Initial API specification for service modules has been made as well.

Copy link
Collaborator

@EddieTheCubeHead EddieTheCubeHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos otherwise really solid.

src/core/OpenAPI/openapi.yaml Outdated Show resolved Hide resolved
@softgitron softgitron marked this pull request as ready for review May 25, 2021 20:14
@softgitron
Copy link
Owner Author

Second draft of the APIs is now ready. Specification should be now pretty ready for prime time, but all comments are always welcome.

There might be still some rough edges in this specification, but I think that minor faults can be smoothed out during development process.

@softgitron softgitron linked an issue May 28, 2021 that may be closed by this pull request
Copy link
Collaborator

@EddieTheCubeHead EddieTheCubeHead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Can be used for recognizing, what action cloud module should take
@softgitron softgitron merged commit 525599e into main Jun 8, 2021
@softgitron softgitron deleted the #6-add-initial-api-specification branch June 8, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add initial API specification
2 participants