-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #6 add initial api specification #11
Conversation
First full core API draft is now available. Please review it. OpenAPI editor can be used for easier visual inspection of the specification. |
Initial API specification for service modules has been made as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typos otherwise really solid.
- Added bound checking - Added format specifiers - Added required markings - Autoformated YAML files using Redhat formatter
Second draft of the APIs is now ready. Specification should be now pretty ready for prime time, but all comments are always welcome. There might be still some rough edges in this specification, but I think that minor faults can be smoothed out during development process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Can be used for recognizing, what action cloud module should take
Short summary of changes in this pull request:
This pull request provides main core and module API definitions in OpenAPI format. OpenAPI format is very useful, since it enables automatic checking of incoming API calls and provides a way to generate documentation of the API automatically.
Short summary of important/debatable decisions and other notable choices made when working on the pull request:
OpenAPI was selected as a language for defining APIs in potku-console.
Other relevant information:
This is very big and important feature. API can be partly altered in the future, but it will be increasingly harder when code base grows. Because of that all discussion is especially welcome related to this PR.