This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Re-implements image listing to sort/filter on jumpgate itself #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| output.append(formatted_image) | ||
| if limit is not None: | ||
| limit -= 1 | ||
| sorted_images = sorted_images[:int(req.get_param('limit'))] |
There was a problem hiding this comment.
What if limit was None here? Now normally, does not make sense to pass marker parameter without a limit parameter but probably need a default here inside this array subset specification. I.e.
sorted_images = sorted_images[:int(req.get_param('limit') or "20")]
There was a problem hiding this comment.
It's hard to read in this diff, but the list is not limited at all if limit isn't passed:
if req.get_param('limit'):
sorted_images = sorted_images[:int(req.get_param('limit'))]But yeah, having a default limit might be good
There was a problem hiding this comment.
You're right, missed the hidden line 158 in all the diff-deletes. This should be fine for now.
|
+1 |
jimlindeman
added a commit
that referenced
this pull request
Aug 7, 2014
Re-implements image listing to sort/filter on jumpgate itself
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue with specifying a marker when listing images not working properly. This solution is not optimal since it sorts and filters client side.