Merge pull request #1071 from Anjana-Rajagopal/feature/NETWORK-8987

NETWORK-8987 - added createDate and modifyDate parameters to sg rule-list
softlayer · Nov 9, 2018 · d6821f3 · d6821f3
2 parents d2e81fe + 543c06b
commit d6821f3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/SoftLayer/CLI/securitygroup/rule.py b/SoftLayer/CLI/securitygroup/rule.py
@@ -15,7 +15,9 @@
            'ethertype',
            'portRangeMin',
            'portRangeMax',
-           'protocol']
+           'protocol',
+           'createDate',
+           'modifyDate']
 
 
 @click.command()
@@ -49,7 +51,9 @@ def rule_list(env, securitygroup_id, sortby):
             rule.get('ethertype') or formatting.blank(),
             port_min,
             port_max,
-            rule.get('protocol') or formatting.blank()
+            rule.get('protocol') or formatting.blank(),
+            rule.get('createDate') or formatting.blank(),
+            rule.get('modifyDate') or formatting.blank()
         ])
 
     env.fout(table)

diff --git a/SoftLayer/managers/network.py b/SoftLayer/managers/network.py
@@ -372,7 +372,7 @@ def get_securitygroup(self, group_id, **kwargs):
                 'description,'
                 '''rules[id, remoteIp, remoteGroupId,
                          direction, ethertype, portRangeMin,
-                         portRangeMax, protocol],'''
+                         portRangeMax, protocol, createDate, modifyDate],'''
                 '''networkComponentBindings[
                     networkComponent[
                         id,

diff --git a/tests/CLI/modules/securitygroup_tests.py b/tests/CLI/modules/securitygroup_tests.py
@@ -118,7 +118,9 @@ def test_securitygroup_rule_list(self):
                            'remoteGroupId': None,
                            'protocol': None,
                            'portRangeMin': None,
-                           'portRangeMax': None}],
+                           'portRangeMax': None,
+                           'createDate': None,
+                           'modifyDate': None}],
                          json.loads(result.output))
 
     def test_securitygroup_rule_add(self):