Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed suspend cloud server order. #1054

Merged
merged 6 commits into from
Oct 11, 2018
Merged

fixed suspend cloud server order. #1054

merged 6 commits into from
Oct 11, 2018

Conversation

FernandoOjeda
Copy link
Contributor

fixed suspend cloud server order #1039

@coveralls
Copy link

coveralls commented Oct 5, 2018

Coverage Status

Coverage increased (+0.03%) to 89.341% when pulling d989dfd on FernandoOjeda:fo_suspend_cloud_server into c15db0e on softlayer:master.

SoftLayer/managers/ordering.py Outdated Show resolved Hide resolved
SoftLayer/managers/ordering.py Outdated Show resolved Hide resolved
SoftLayer/managers/ordering.py Outdated Show resolved Hide resolved
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not suggesting moving all the price_id logic into one method, but this will make the code easier to maintain in the long run.

SoftLayer/managers/ordering.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff merged commit 3a50f46 into softlayer:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants