Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use click 7 #1055

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Conversation

felixonmars
Copy link
Contributor

The option reordering is related to pallets/click#1140

These changes fix most test failures here.

@felixonmars
Copy link
Contributor Author

Not really sure why test_edit_perms_on_bad is still failing, though :/

@allmightyspiff
Copy link
Member

Weird... I'm not sure why that test was ever -1, even though I wrote it. Testing on the current version shows that command should have an exit code of 1, not -1. Feel free to update that test.

$ pip show click
Name: click
Version: 6.7
$ slcli user edit-permissions 6892509 --enable -p THIS_DOESNT_EXIST
'THIS_DOESNT_EXIST' is not a valid permission
(py36)
allmi@SPF-WIN10 MINGW64 ~/Source/softlayer-python (1026)
$ echo $?
1
(py36)
allmi@SPF-WIN10 MINGW64 ~/Source/softlayer-python (1026)
$ slcli user create test -e test@us.ibm.com -t '{firstName: "Supermand"}'
Argument Error: Unable to parse --template. Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
(py36)
allmi@SPF-WIN10 MINGW64 ~/Source/softlayer-python (1026)
$ echo $?
2
(py36)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.324% when pulling 3b76899 on felixonmars:new-click into 17cae65 on softlayer:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants