Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slcli vs create by router data. #1414

Merged
merged 6 commits into from Feb 26, 2021
Merged

Add slcli vs create by router data. #1414

merged 6 commits into from Feb 26, 2021

Conversation

FernandoOjeda
Copy link
Contributor

Add slcli vs create by router data #1412.

@FernandoOjeda FernandoOjeda self-assigned this Feb 5, 2021
@allmightyspiff allmightyspiff added CLI Ordering Anything related to ordering labels Feb 5, 2021
@allmightyspiff allmightyspiff added this to In progress in Q1 2021 via automation Feb 5, 2021
allmightyspiff
allmightyspiff requested changes Feb 5, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would recommend combining get_network_components and create_network_components into one function. Basically just add your check for the exception to create_network_components and I think it wil work as you expect.

SoftLayer/managers/vs.py Outdated Show resolved Hide resolved
SoftLayer/managers/vs.py Outdated Show resolved Hide resolved
SoftLayer/managers/vs.py Outdated Show resolved Hide resolved
SoftLayer/managers/vs.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff linked an issue Feb 5, 2021 that may be closed by this pull request
Create a Virtual Server by backend/frondend router id. #1412
Closed
ATGE
ATGE approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

allmightyspiff
allmightyspiff approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

caberos
caberos approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@caberos caberos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@allmightyspiff allmightyspiff merged commit 0558eab into softlayer:master Feb 26, 2021
Q1 2021 automation moved this from In progress to Done Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@caberos caberos caberos approved these changes

@ATGE ATGE ATGE approved these changes

Assignees

@FernandoOjeda FernandoOjeda

Labels
CLI Ordering Anything related to ordering
Projects
No open projects
Q1 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Virtual Server by backend/frondend router id.
4 participants
@FernandoOjeda @allmightyspiff @caberos @ATGE