Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a flags in the report bandwidth #1420

Merged
merged 8 commits into from Feb 26, 2021
Merged

add a flags in the report bandwidth #1420

merged 8 commits into from Feb 26, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Feb 12, 2021

allmightyspiff
allmightyspiff requested changes Feb 19, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to refactor the Try/Except blocks, otherwise looks good, thanks.

SoftLayer/CLI/report/bandwidth.py Outdated Show resolved Hide resolved
@allmightyspiff allmightyspiff added this to In progress in Q1 2021 via automation Feb 19, 2021
@allmightyspiff allmightyspiff linked an issue Feb 19, 2021 that may be closed by this pull request
add flag on slcli report bandwidth summary #1419
Closed
ATGE
ATGE approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

SoftLayer/CLI/report/bandwidth.py Outdated Show resolved Hide resolved
SoftLayer/CLI/report/bandwidth.py Outdated Show resolved Hide resolved
ATGE
ATGE approved these changes Feb 24, 2021
View reviewed changes
SoftLayer/CLI/custom_types.py
@@ -9,6 +9,7 @@
import click


# pylint: disable=inconsistent-return-statements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to disable in the method convert as:
def convert(self, value, param, ctx): # pylint: disable=R1710

setup.py
@@ -4,6 +4,8 @@

from setuptools import setup, find_packages

# pylint: disable=inconsistent-return-statements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to disable in the method get_api_key as:
def get_api_key(client, username, secret): # pylint: disable=R1710

allmightyspiff
allmightyspiff approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@allmightyspiff allmightyspiff merged commit 4156741 into softlayer:master Feb 26, 2021
Q1 2021 automation moved this from In progress to Done Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@ATGE ATGE ATGE approved these changes

@FernandoOjeda FernandoOjeda Awaiting requested review from FernandoOjeda

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q1 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add flag on slcli report bandwidth summary
3 participants
@caberos @allmightyspiff @ATGE