Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add billing and lastTransaction on hardware detail #1446

Merged
merged 3 commits into from Apr 9, 2021
Merged

add billing and lastTransaction on hardware detail #1446

merged 3 commits into from Apr 9, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Mar 24, 2021

@allmightyspiff allmightyspiff added this to In progress in Q1 2021 via automation Mar 26, 2021
@allmightyspiff allmightyspiff linked an issue Mar 26, 2021 that may be closed by this pull request
add 'Billing' and 'lastTransaction' on slcli hardware detail #1445
Closed
allmightyspiff
allmightyspiff requested changes Mar 26, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the date to the transaction output, and use utils.lookup incase you get a server that doesn't have a last transaction for some wild reason.

SoftLayer/CLI/hardware/detail.py Outdated Show resolved Hide resolved
@allmightyspiff
Copy link
Member

Can you add the date to the last transaction column as well, I think that would be good to know if were going to be displaying that.

ATGE
ATGE approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

  • ✔️ $ slcli hw detail 1403539 | grep last_transaction
    last_transaction CENT OS Reload (2020-07-24T10:12:00-06:00)
  • ✔️$ slcli hw detail 1403539 | grep billing
    billing Monthly

looks good

FernandoOjeda
FernandoOjeda approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@allmightyspiff allmightyspiff merged commit 3db1007 into softlayer:master Apr 9, 2021
Q1 2021 automation moved this from In progress to Done Apr 9, 2021
@allmightyspiff allmightyspiff mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

@ATGE ATGE ATGE approved these changes

@FernandoOjeda FernandoOjeda FernandoOjeda approved these changes

Assignees

@caberos caberos

Labels
CLI
Projects
No open projects
Q1 2021
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add 'Billing' and 'lastTransaction' on slcli hardware detail
4 participants
@caberos @allmightyspiff @ATGE @FernandoOjeda